Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spelling action #1590

Closed
wants to merge 3 commits into from
Closed

spelling action #1590

wants to merge 3 commits into from

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Jan 22, 2025

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Add a summary here: What does this PR add/change and why?

2. Jira task / GitHub issue

Is this a GitHub issue? --> Add the link to the github issue

Is this from a Jira task? --> If your branch does not contain info regarding the Jira task ID, put it here.

3. Type of change - Add label

What type of change(s) does the PR contain? For an explanation of the different options below, enter edit mode of this PR description template.

If you do not want this change to be included in release notes, add the label skip-changelog.

  • New feature
    • Breaking --> label: breaking
    • Non-breaking --> label: feature
  • Database change --> label: feature or none at all.
    Remember the to include a new migration version, or explain here why it's not needed.
  • Bug fix --> label: bug
  • Security Alert fix
    • Package update --> label: dependency
      • Major version update
  • Documentation --> label can be skipped, will be included in "other changes"
  • Workflow --> label: skip-changelog
  • Tests only --> label: skip-changelog

4. Additional information

5. Actions / Scans

Make sure that the following checks/actions have passed.

  • Black
  • Prettier
  • Yamllint
  • Tests
  • CodeQL
  • Trivy
  • Snyk

If an action does not pass and you need help with how to solve it, enter edit mode of this PR template or go to the PR template.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.55%. Comparing base (b5e4716) to head (3303d54).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1590   +/-   ##
=======================================
  Coverage   92.55%   92.55%           
=======================================
  Files          29       29           
  Lines        4892     4892           
=======================================
  Hits         4528     4528           
  Misses        364      364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@i-oden
Copy link
Member Author

i-oden commented Jan 27, 2025

Not important, just me playing around.

@i-oden i-oden closed this Jan 27, 2025
@i-oden i-oden deleted the spell-check branch January 27, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant